Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed auth issues #510

Merged
merged 5 commits into from
Nov 21, 2023
Merged

Fixed auth issues #510

merged 5 commits into from
Nov 21, 2023

Conversation

AsafMah
Copy link
Collaborator

@AsafMah AsafMah commented Nov 20, 2023 •
edited
Loading

  • Tests are properly skipped and are correctly disabled when needed
  • E2E can now run without app_key variables

@AsafMah AsafMah requested a review from yogilad November 20, 2023 13:17
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2023 •
edited
Loading

Test Results

       5 files  ±0         5 suites  ±0   20m 21s ⏱️ + 3m 52s
   285 tests ±0     265 ✔️  - 19  19 💤 +18  1 ❌ +1 
1 425 runs  ±0  1 325 ✔️  - 95  95 💤 +90  5 ❌ +5 

For more details on these failures, see this check.

Results for commit 9e62958. ± Comparison against base commit 4519043.

This pull request skips 18 tests. 
azure-kusto-data.tests.aio.test_async_token_providers.TestTokenProvider ‑ test_app_cert_provider
azure-kusto-data.tests.aio.test_async_token_providers.TestTokenProvider ‑ test_az_provider
azure-kusto-data.tests.aio.test_async_token_providers.TestTokenProvider ‑ test_device_auth_provider
azure-kusto-data.tests.aio.test_async_token_providers.TestTokenProvider ‑ test_msi_provider
azure-kusto-data.tests.aio.test_async_token_providers.TestTokenProvider ‑ test_user_pass_provider
azure-kusto-data.tests.aio.test_async_token_providers.TokenProviderTests ‑ test_app_cert_provider
azure-kusto-data.tests.aio.test_async_token_providers.TokenProviderTests ‑ test_az_provider
azure-kusto-data.tests.aio.test_async_token_providers.TokenProviderTests ‑ test_device_auth_provider
azure-kusto-data.tests.aio.test_async_token_providers.TokenProviderTests ‑ test_interactive_login
azure-kusto-data.tests.aio.test_async_token_providers.TokenProviderTests ‑ test_msi_provider
…

♻️ This comment has been updated with latest results.

@AsafMah AsafMah merged commit 20ae9cc into master Nov 21, 2023
4 of 10 checks passed
@AsafMah AsafMah deleted the fix-e2e-cred branch November 21, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yogilad yogilad Awaiting requested review from yogilad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AsafMah